Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing from cart and add Not Found UI #35

Conversation

bc-yevhenii-buliuk
Copy link
Collaborator

What?

This PR fixes the removal of items from the cart when using the "reduce quantity" button.
Also, this PR adds the display of the Not Found user interface on non-existing pages.

Screenshots/Videos

before

1760_bug.mov

after

1760_fix.mov

before

1760_error_not_found

after

1760_add_not_found_ui

Copy link

vercel bot commented Dec 22, 2023

Someone is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

@bc-yevhenii-buliuk
Copy link
Collaborator Author

@bigcommerce/team-themes Team, could you do a review of this PR? Thanks!

Copy link
Collaborator

@BC-krasnoshapka BC-krasnoshapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@bc-alexsaiannyi bc-alexsaiannyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

@yurytut1993 yurytut1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants