Skip to content

DEVDOCS-6035: [update] geography nodes #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

bc-traciporter
Copy link
Contributor

@bc-traciporter bc-traciporter commented Apr 15, 2025

DEVDOCS-6035

What changed?

Added an example for the geography node

Release notes draft

Anything else?

ping {names}

@bc-traciporter bc-traciporter added the ready for review This PR is complete and awaiting a review. label Apr 15, 2025
@myope1
Copy link

myope1 commented May 1, 2025

@kskomro can you review this PR?

@markcmurphy markcmurphy requested a review from Copilot May 1, 2025 18:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • docs/storefront/graphql/examples/index.mdx: Language not supported

Copy link
Contributor

@kskomro kskomro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this query should be split in two queries -site.settings.shipping.supportedShippingDestinations and geography - and also then returned results by each can be described separately. Furthermore geography node has filers which should be explained.

bc-terra and others added 2 commits May 12, 2025 08:21
Incorporating suggestion to split queries and include explicit mention of the country filters on `geography`
@bc-terra
Copy link
Contributor

I think this query should be split in two queries -site.settings.shipping.supportedShippingDestinations and geography - and also then returned results by each can be described separately. Furthermore geography node has filers which should be explained.

@kskomro I agree that it is a bit clearer to separate it, so I've split up the example into queries and responses for the two separate methods of retrieving the data. I've also moved the note regarding structure outside of the request and added a note about the geography filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is complete and awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants