-
Notifications
You must be signed in to change notification settings - Fork 43
DEVDOCS-6035: [update] geography nodes #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@kskomro can you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- docs/storefront/graphql/examples/index.mdx: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this query should be split in two queries -site.settings.shipping.supportedShippingDestinations and geography - and also then returned results by each can be described separately. Furthermore geography node has filers which should be explained.
Co-authored-by: Kamil Skomro <[email protected]>
Incorporating suggestion to split queries and include explicit mention of the country filters on `geography`
@kskomro I agree that it is a bit clearer to separate it, so I've split up the example into queries and responses for the two separate methods of retrieving the data. I've also moved the note regarding structure outside of the request and added a note about the |
DEVDOCS-6035
What changed?
Added an example for the geography node
Release notes draft
Anything else?
ping {names}