docs(orders): DEVDOCS-6330 [REST Storefront] [Orders] Add missing values for "include" query param #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues for "include" query param
Comment on lines
+58
to
+61
| - lineItems.physicalItems | ||
| - lineItems.physicalItems.socialMedia | ||
| - lineItems.physicalItems.options | ||
| - lineItems.physicalItems.categories |
There was a problem hiding this comment.
Suggested change
| - lineItems.physicalItems | |
| - lineItems.physicalItems.socialMedia | |
| - lineItems.physicalItems.options | |
| - lineItems.physicalItems.categories | |
| - lineItems.physicalItems | |
| - lineItems.physicalItems.giftWrapping | |
| - lineItems.physicalItems.socialMedia | |
| - lineItems.physicalItems.options | |
| - lineItems.physicalItems.categories |
There was a problem hiding this comment.
I didn't include gift wrapping as that is always included by default. So adding the parameter wont have an effect
| - lineItems.physicalItems | ||
| - lineItems.physicalItems.socialMedia | ||
| - lineItems.physicalItems.options | ||
| - lineItems.physicalItems.categories |
There was a problem hiding this comment.
probably out of scope of this PR: should we also update the schema for the "ItemPhysical.categories" :
Lines 339 to 344 in b874b60
| @@ -55,12 +55,22 @@ paths: | |||
| type: string | |||
| enum: | |||
| - lineItems | |||
| - lineItems.physicalItems | |||
| - lineItems.physicalItems.socialMedia | |||
| - lineItems.physicalItems.options | |||
There was a problem hiding this comment.
Seems like options attribute is not definied in the ItemPhysical 🤔
| @@ -55,12 +55,22 @@ paths: | |||
| type: string | |||
| enum: | |||
| - lineItems | |||
| - lineItems.physicalItems | |||
| - lineItems.physicalItems.socialMedia | |||
There was a problem hiding this comment.
socialMedia attribute also not defined in ItemPhysical
|
Ah I see we are still missing in the response body. Ill add those in as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
DEVDOCS-6330
What changed?
Release notes draft
Anything else?
ping @bigcommerce/team-orders