Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-5966: [update] correct contentType #507

Merged
merged 16 commits into from
Sep 12, 2024
Merged

Conversation

bc-traciporter
Copy link
Contributor

@bc-traciporter bc-traciporter commented Sep 9, 2024

DEVDOCS-5966

What changed?

Added new contentType for the image endpoints

Release notes draft

Bug Fix: corrected invalid Content-Type for image upload endpoints

Anything else?

ping {names}

@bc-traciporter
Copy link
Contributor Author

Now these endpoints should like the following:

Screenshot 2024-09-09 at 9 54 11 PM

@bc-traciporter bc-traciporter added the ready for review This PR is complete and awaiting a review. label Sep 9, 2024
olysenko
olysenko previously approved these changes Sep 10, 2024
@bc-traciporter
Copy link
Contributor Author

Hi @alex-gaiduchok Thank you so much because I did miss that part. Can you review my changes? I updated the usage notes as well as adding enum values for the content-type.

Screenshot 2024-09-10 at 10 28 59 PM

@bc-traciporter
Copy link
Contributor Author

@alex-gaiduchok your comment was just for catalog-products right or was I supposed to update all of them?

@alex-gaiduchok
Copy link
Contributor

@alex-gaiduchok your comment was just for catalog-products right or was I supposed to update all of them?

@bc-traciporter tbh its a good question to catalog team, I just worked with product images for a while.

@bc-traciporter bc-traciporter merged commit 6cf2f76 into main Sep 12, 2024
3 checks passed
@bc-traciporter bc-traciporter deleted the DEVDOCS-5966 branch September 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR is complete and awaiting a review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants