Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVDOCS-6034 [update]: Settings API, update docs for channel overrides #448

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bc-andreadao
Copy link
Collaborator

@bc-andreadao bc-andreadao commented Aug 13, 2024

DEVDOCS-6034

This PR addresses issue 388

Relevant slack conversation

What changed?

Get Locale Settings & Update Locale Settings endpoint:

  • add channel_id query parameter
  • Response body: if there are no channel overrides, data will be null

Update Locale Settings endpoint:

  • Document how to remove overrides (set each field to null)

Release notes draft

N / A

Anything else?

@bigcommerce/team-multi-storefront

Copy link
Contributor

@funivan funivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to talk with product first.

Blocking this PR because of this change: - $ref: '#/components/parameters/ChannelIdParam'

@bc-andreadao
Copy link
Collaborator Author

Thanks @funivan, keep me in the loop on the conversation

@kristinapototska
Copy link

@bc-andreadao is there someone requesting this change to documentation?
I'm asking, because we have intentionally removed this from documentation as we are not planning to make this change public and instead we will be release a separate API endpoint to manage locales per channel.

@bc-andreadao
Copy link
Collaborator Author

bc-andreadao commented Aug 16, 2024

@kristinapototska Yes, the PR was created to address #388 from an external developer. However, I can close out the PR and notify them that we're planning to release a separate API endpoint in the future, if that's what you'd prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants