PROMO-1050 Add shipping discount action #358
Conversation
bc-luke
force-pushed
the
promo-1050-new-shipping-action
branch
from
939d4bc
to
cb53225
Compare
bc-luke
force-pushed
the
promo-1050-new-shipping-action
branch
from
35523bf
to
fd39e6d
Compare
| type: integer | ||
| minimum: 1 | ||
| required: | ||
| - method_ids |
There was a problem hiding this comment.
discount is probably required as well 😄
reference/promotions.v3.yml
Outdated
| properties: | ||
| discount: | ||
| $ref: '#/components/schemas/Discount' | ||
| as_total: |
There was a problem hiding this comment.
I didn't notice this during initial UX review.
I'm wondering if this can be omitted to "per destination" for the 1st iteration ? distribute as a total amount is definitely doable engineering wise, but from past experience, it's also a source of rounding bugs, so we only want to take on the additional complexity when we're sure that the demand is there.
Probably worth asking JW to confirm if this is required for WD, if not, we can reduce the scope a bit.
There was a problem hiding this comment.
Agreed! Let's see if we can limit it to per desitination then expand with this later if needed.
| description: List of shipping method IDs to which the shipping discount can apply. | ||
| items: | ||
| type: integer | ||
| minimum: 1 |
There was a problem hiding this comment.
Do we want to enforce some sort of sanity check maximum? Just so we don't inevitably have merchants finding creative ways to abuse this and potentially listing hundreds of shipping methods? We can always increase the limit if discover a legit use case
PROMO-1050
What changed?
This is based on the mockup shown here:
Release notes draft
TBC
Anything else?
ping {names}