feat(tax): TAX-1995 Add specs for new TaxZone check endpoint #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpratt77
force-pushed
the
TAX-1995
branch
3 times, most recently
from
14432ab
to
d6a8d27
Compare
bc-luke
reviewed
Jan 10, 2024
bc-luke
reviewed
Jan 10, 2024
bc-luke
reviewed
Jan 10, 2024
theromulans
reviewed
Jan 16, 2024
theromulans
reviewed
Jan 16, 2024
theromulans
reviewed
Jan 16, 2024
agchan12
reviewed
Jan 16, 2024
theromulans
reviewed
Jan 16, 2024
theromulans
reviewed
Jan 16, 2024
bc-luke
approved these changes
Jan 17, 2024
|
Work continued in PR 54 |
| content: | ||
| application/json: | ||
| schema: | ||
| type: array |
There was a problem hiding this comment.
Testing around, it seems like the request is an object (instead of an array), so I fixed the doc in PR 54
| type: object | ||
| properties: | ||
| data: | ||
| type: array |
There was a problem hiding this comment.
Same thing here, my testing showed data is an object, not an array, so fixed in PR 54
bc-tgomez
pushed a commit
that referenced
this pull request
Apr 26, 2024
# [DEVDOCS-5714] Add documentation in api-specs repo for our new ZoneCheck endpoint https://bigcommercecloud.atlassian.net/browse/TAX-1995 ## What changed? * Added new spec file for the `tax/zonecheck` endpoint ## Anything else? bigcommerce/api-proxy-java#2659 (comment) Specs match the response: <img width="1309" alt="Screenshot 2023-12-29 at 10 28 52 am" src="https://github.com/bigcommerce/docs/assets/40374950/c84912fd-bb52-45af-962c-30c2cdb49b82"> ping @bigcommerce/team-shipping [DEVDOCS-5714]: https://bigcommercecloud.atlassian.net/browse/DEVDOCS-5714?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVDOCS-5714
Add documentation in api-specs repo for our new ZoneCheck endpoint
https://bigcommercecloud.atlassian.net/browse/TAX-1995
What changed?
tax/zonecheckendpointAnything else?
https://github.com/bigcommerce/api-proxy-java/pull/2659#issuecomment-1859527805
Specs match the response:
ping @bigcommerce/team-shipping