Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-1906 High severity security issue #2477

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

bc-vlad-dlogush
Copy link
Contributor

@bc-vlad-dlogush bc-vlad-dlogush commented Jul 18, 2024

Jira: BCTHEME-1906

What/Why?

This PR updates the affected packages

@BC-krasnoshapka
Copy link
Contributor

@VladDlogush there is an error during build most likely related to this changes:

Validation Error:
Test environment jest-environment-jsdom cannot be found. Make sure the testEnvironment configuration option points to an existing node module.

@sacr3dc0w
Copy link
Contributor

@VladDlogush there is an error during build most likely related to this changes:

Validation Error:
Test environment jest-environment-jsdom cannot be found. Make sure the testEnvironment configuration option points to an existing node module.

I had this issue on another project. Jest no longer ships jsdom, or jasmine2. To resolve, run npm i jest-environment-jsdom jest-jasmine2 --save-dev to add to the dependency tree.

@bc-vlad-dlogush bc-vlad-dlogush force-pushed the BCTHEME-1906 branch 4 times, most recently from fc4ecb2 to c61e4d0 Compare July 19, 2024 12:22
@bc-vlad-dlogush bc-vlad-dlogush requested a review from a team July 19, 2024 12:33
jest.setup.js Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@bc-vlad-dlogush bc-vlad-dlogush merged commit 3eb0cd2 into master Jul 31, 2024
3 checks passed
@bc-vlad-dlogush bc-vlad-dlogush deleted the BCTHEME-1906 branch July 31, 2024 07:13
@mattcoy-arcticleaf
Copy link
Contributor

@bc-vlad-dlogush lighthouse 12 is not compatible with Node 18.15. Should this be rolled back or should the .nvmrc file be updated to a newer version of Node?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants