Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form validation fix #2475

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

Dpschu2
Copy link
Contributor

@Dpschu2 Dpschu2 commented Jul 15, 2024

What?

Adding name field validation message for product reviews form.

Screenshots

Added name field validation

@BC-krasnoshapka BC-krasnoshapka requested a review from a team July 16, 2024 09:34
@bc-yevhenii-buliuk
Copy link
Contributor

@Dpschu2 please add a description to the PR and a corresponding screenshot/video confirming the fix. Thanks!

@Dpschu2
Copy link
Contributor Author

Dpschu2 commented Jul 16, 2024

Added the screenshot showing the field message that was missing. The description already describes what was added/missing.

@bc-yevhenii-buliuk
Copy link
Contributor

bc-yevhenii-buliuk commented Jul 16, 2024

Added the screenshot showing the field message that was missing. The description already describes what was added/missing.

please also remove tickets / documentation block from description if we don't have tickets for it

Also please do not forget to squash commits with one appropriate message

@Dpschu2
Copy link
Contributor Author

Dpschu2 commented Jul 16, 2024

Description updated. How do you squash commits?

Here is what I tried. Did that work?
image

@bc-yevhenii-buliuk
Copy link
Contributor

bc-yevhenii-buliuk commented Jul 16, 2024

Description updated. How do you squash commits?

Here is what I tried. Did that work? image

yep, you can use git rebase -i HEAD~3 and after that in editor use commands pick and squash to define main commit. As result you will get one commit instead of three.

@Dpschu2
Copy link
Contributor Author

Dpschu2 commented Jul 16, 2024

I originally did that by making the first one 'pick' and the last 2 'squash'. Doing it now gives me commits from past PRs:
image

@Dpschu2
Copy link
Contributor Author

Dpschu2 commented Jul 16, 2024

Here is what I did:
Screenshot 2024-07-16 at 12 53 14 PM

image

@bookernath
Copy link
Contributor

@Dpschu2 do you mind doing a rebase? I tried to do it for you but I don't have access to your fork. This is good to go after rebase.

@bookernath bookernath merged commit 3967d64 into bigcommerce:master Oct 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants