Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account.js template literal fix #2464

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

Dpschu2
Copy link
Contributor

@Dpschu2 Dpschu2 commented May 16, 2024

What?

line 414 of account.js should have a template literal

Requirements

  • CHANGELOG.md entry added (required for code changes only)

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

Attach images or add image links here.

Example Image

@BC-krasnoshapka BC-krasnoshapka requested a review from a team May 17, 2024 12:28
@bc-vlad-dlogush
Copy link
Contributor

@Dpschu2 Could you add the CHANGELOG.md?

@Dpschu2
Copy link
Contributor Author

Dpschu2 commented May 21, 2024

Changelog added

@bc-vlad-dlogush
Copy link
Contributor

These changes will go into the next release, so we add as a draft, like this:

## Draft
- Account.js - Fixed jquery selector to be template literal [#2464](https://github.com/bigcommerce/cornerstone/pull/2464)

Copy link
Contributor Author

@Dpschu2 Dpschu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog fix

@Dpschu2
Copy link
Contributor Author

Dpschu2 commented May 22, 2024

Thanks for letting me know. That is updated

@BC-krasnoshapka BC-krasnoshapka merged commit 7b738c0 into bigcommerce:master May 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants