feat(payment): PAYPAL-4550 added force reload of paypal client to avo…

…id initializaing with wrong intent value
bigcommerce · Aug 14, 2024 · 8b39cfa · 8b39cfa
1 parent 456e2bf
commit 8b39cfa
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 4 deletions.
diff --git a/...commerce-alternative-methods/paypal-commerce-alternative-methods-payment-strategy.spec.ts b/...commerce-alternative-methods/paypal-commerce-alternative-methods-payment-strategy.spec.ts
@@ -231,6 +231,9 @@ describe('PayPalCommerceAlternativeMethodsPaymentStrategy', () => {
 
             expect(paypalCommerceIntegrationService.loadPayPalSdk).toHaveBeenCalledWith(
                 defaultMethodId,
+                undefined,
+                undefined,
+                true,
             );
         });
     });

diff --git a/...ypal-commerce-alternative-methods/paypal-commerce-alternative-methods-payment-strategy.ts b/...ypal-commerce-alternative-methods/paypal-commerce-alternative-methods-payment-strategy.ts
@@ -84,7 +84,12 @@ export default class PayPalCommerceAlternativeMethodsPaymentStrategy implements
             return;
         }
 
-        await this.paypalCommerceIntegrationService.loadPayPalSdk(methodId);
+        await this.paypalCommerceIntegrationService.loadPayPalSdk(
+            methodId,
+            undefined,
+            undefined,
+            true,
+        );
 
         this.loadingIndicatorContainer = paypalOptions.container.split('#')[1];
 

diff --git a/packages/paypal-commerce-integration/src/paypal-commerce-script-loader.ts b/packages/paypal-commerce-integration/src/paypal-commerce-script-loader.ts
@@ -54,7 +54,7 @@ export default class PayPalCommerceScriptLoader {
             const scriptQuery = new URLSearchParams(options).toString();
             const scriptSrc = `${paypalSdkUrl}?${scriptQuery}`;
 
-            await this.scriptLoader.loadScript(scriptSrc, { async: true, attributes });
+            await this.scriptLoader.loadScript(scriptSrc, { async: true, attributes }, forceLoad);
         }
 
         if (!this.window.paypal) {

diff --git a/...paypal-commerce-integration/src/paypal-commerce/paypal-commerce-customer-strategy.spec.ts b/...paypal-commerce-integration/src/paypal-commerce/paypal-commerce-customer-strategy.spec.ts
@@ -287,7 +287,12 @@ describe('PayPalCommerceCustomerStrategy', () => {
         it('loads paypal sdk with provided method id', async () => {
             await strategy.initialize(initializationOptions);
 
-            expect(paypalCommerceIntegrationService.loadPayPalSdk).toHaveBeenCalledWith(methodId);
+            expect(paypalCommerceIntegrationService.loadPayPalSdk).toHaveBeenCalledWith(
+                methodId,
+                undefined,
+                undefined,
+                true,
+            );
         });
     });
 

diff --git a/...ages/paypal-commerce-integration/src/paypal-commerce/paypal-commerce-customer-strategy.ts b/...ages/paypal-commerce-integration/src/paypal-commerce/paypal-commerce-customer-strategy.ts
@@ -74,7 +74,12 @@ export default class PayPalCommerceCustomerStrategy implements CustomerStrategy
             await this.paymentIntegrationService.loadPaymentMethod(methodId);
         }
 
-        await this.paypalCommerceIntegrationService.loadPayPalSdk(methodId);
+        await this.paypalCommerceIntegrationService.loadPayPalSdk(
+            methodId,
+            undefined,
+            undefined,
+            true,
+        );
 
         this.renderButton(methodId, paypalcommerce);
     }