feat(core): add locale switcher to Header #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
jorgemoya
changed the title
chanceaclark
approved these changes
Jan 14, 2025
Comment on lines
23
to
27
|
|
||
| if (submission.value.id === defaultLocale) { |
There was a problem hiding this comment.
I would just add a comment why we need to do this.
Suggested change
| if (submission.value.id === defaultLocale) { | |
| // Since `redirect` doesn't prepend the local to the redirect url | |
| // when navigating the a default locale link, we need to prepend | |
| // it ourselves to ensure the redirect happens. | |
| if (submission.value.id === defaultLocale) { |
jorgemoya
force-pushed
the
add-locale-switcher
branch
from
a0ed3c8 to
9fd43e0
Compare
bookernath
pushed a commit
that referenced
this pull request
Jan 17, 2025
* feat(core): add locale switcher to Header * fix: add translation for error * chore: add context comment
BC-krasnoshapka
pushed a commit
that referenced
this pull request
Jan 23, 2025
* feat(core): add locale switcher to Header * fix: add translation for error * chore: add context comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Add locale switcher to the Header, using server action and
redirect. In this use case we need to revalidate the/to make sure the cookies get updated with the new locale. We also had to workaround an issue by redirecting to the/enwhen the default locale is used.Testing
Locale switcher works as expected.
Kapture.2025-01-14.at.11.50.02.mp4