Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade pyext dependency #265

Merged

Conversation

shehrozek-cerebras
Copy link
Contributor

@shehrozek-cerebras shehrozek-cerebras commented Aug 29, 2024

Currently, the pyext package dependency is pinned to version 0.7. However, this yields the following error with Python 3.11 when trying to install bigcode-eval package via pip:

oargspec = inspect.getargspec
           ^^^^^^^^^^^^^^^^^^
      AttributeError: module 'inspect' has no attribute 'getargspec'. Did you mean: 'getargs'?

pyext==0.7 doesn't look like an official release version (https://pypi.org/project/pyext/#history) and so it doesn't seem like this issue will be fixed any time soon to work with the newer version of Python

So in order to make bigcode-eval work with Python 3.11, this change downgrades the pyext package pin to 0.5. Note that there was a PR (#181) raised to address this issue previously, but not sure why it got closed.

@shehrozek-cerebras
Copy link
Contributor Author

CC: @loubnabnl for reviews. Thanks!

Copy link
Collaborator

@loubnabnl loubnabnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@loubnabnl loubnabnl merged commit f0b81a9 into bigcode-project:main Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants