Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use updated ISO-4217 for currencies #756

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

svn-arc
Copy link

@svn-arc svn-arc commented Nov 17, 2024

The library currently being used for the list of currencies js-money is out of date. i.e., it uses an outdated currency code for Zambian Kwacha (ZMK) and Belarusian Ruble (BYR). This makes it impossible to select either currency as the base currency on the web app. We get a validation error.

There is a pull request on the library, but it's been pending for 6 years.

This PR:

  1. Removes out of circulation currencies (EEK,LTL,LVL)
  2. Changes currency codes (BYR to BYN, ZMK to ZMW)

@mvdgun
Copy link

mvdgun commented Dec 4, 2024

@svn-arc check out this issue for more currency related issues. Perhaps you can include those currencies as well and fix more issues with this PR: #724

@abouolia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants