feat(plugin): add self-view disable as a ui-command #139
+105
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to disable self view to all devices that a user has
|
This pull request has conflicts ☹ |
GuiLeme
changed the title
…ViewDisabled for specific streamID
GuiLeme
force-pushed
the
self-view-disabled
branch
from
aa9fb48 to
a8e2341
Compare
| ]); | ||
| } | ||
| }, [currentPresentation, currentUser, showingGenericContentInPresentationArea, isCamerasOnly]); | ||
| }, [currentPresentation, currentUser, showingGenericContentInPresentationArea]); |
There was a problem hiding this comment.
Is it not necessary to add isSelfViewDisabled as a dependency in this useEffect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
How to test
Suit yourself to test it in whatever plugin you'd like, but, I recommend the sampleActionsButtonDropdown once it already has this feature.
More
Closely related to bigbluebutton/bigbluebutton#21896
See demo below:
disableSelfViewDemo.mp4