Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTI-279: use params from broker for room handler if specified #251

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Mariam05
Copy link
Collaborator

@Mariam05 Mariam05 commented Oct 20, 2023

Description
A custom 'handler_params' setting can be added to tenants in the broker via the new rake task. These params can be used in the rooms app to form the room handler. By default, if no params are specified in the broker, the app will use the 'resource_link_id' parameter to form the handler.

How to Specify Params

# The rake task first takes a tenant's uid. the second parameter must be 'handler_params', and the third parameter is a string with as many params as you like, separated by an escaped comma, as shown below:
rake db:tenants:settings:upsert[tenant_id,handler_params,"context_id\,resource_link_id"] 

# You can delete handler parameters by using the following task:
rake db:tenants:settings:delete_handler_params[tenant_uid,handler_params]

Things to Note
Ensure that you are using the correct version of the Broker that supports using handler params from the broker.
By changing the params used for the handler will change, you will lose previous instances of Rooms. They won't be deleted from the database, but rather if you launch a Room that had been previously set up, it will be launched as a new room. The major consequence of this is that any recordings in the previous room will be lost.

How to test
In the broker, specify the params you would like to use for your tenant's rooms, and then create various rooms within one course and across a couple of courses, ensuring that the rooms are unique (this can be done by simply changing the room name or description).

@Mariam05 Mariam05 requested a review from jfederico October 20, 2023 16:10
Copy link
Member

@jfederico jfederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge it because the urgency of solving a particular problem, but the step we follow on launch to pull credentials needs to be reviewed. It should probably use this same method in the broker helper

@jfederico jfederico merged commit 0875db8 into bigbluebutton:master Oct 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants