Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation namespace #925

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Add translation namespace #925

merged 2 commits into from
Oct 30, 2023

Conversation

farhanlatheef
Copy link
Contributor

@farhanlatheef farhanlatheef commented Oct 30, 2023

Description

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.
- [ ] I have verified the functionality in some of the neeto web-apps.
- [ ] I have added the necessary label (patch/minor/major - If package publish
is required).

Reviewers

@farhanlatheef
Copy link
Contributor Author

@AbhayVAshokan _a Please review.

@bot-bigbinary
Copy link
Contributor

Cannot auto-update because of conflicts.

Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please resolve the conflicts and merge it yourself.
I'll resolve the merge conflicts and merge.

@AbhayVAshokan AbhayVAshokan added the patch Releases small requests or bug fixes. label Oct 30, 2023
@AbhayVAshokan AbhayVAshokan merged commit 79a4404 into main Oct 30, 2023
@AbhayVAshokan AbhayVAshokan deleted the fc-trans-namespace branch October 30, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants