-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a popover for adding links to editor content #904
Conversation
Cannot auto-update because of conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaagul _a
There are a few issues with this approach:
- Pressing enter should submit the form. Instead, it is replacing the text content.
- Add more spacing between the two inputs and the buttons (use
space-y-2
). - Update the label of the
link
button toDone
. - The placement of the popover is wrong. So it's more confusing.
- Use the
useOnClickOutside
hook from neeto-commons-frontend to close the popover when the user clicks outside.
e8a9479
to
fab2df7
Compare
@AbhayVAshokan _a Please review the new changes to UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the mic was on mute while you were recording. |
@gaagul: I have recorded it again: https://vimeo.com/875156777/1072dfa383?share=copy |
@AbhayVAshokan _a I have fixed the issues and verified the changes, could you please verify it once more to find out whether I have missed any edge cases. |
@gaagul _a in order to close the popover I need to click within the editor itself. I need to close it by clicking it anywhere. |
@AbhayVAshokan I will merge the PR myself after fixing this outsideClick issue if everything else looks good. |
Description
Checklist
- [ ] I have made corresponding changes to the documentation.- [ ] I have updated the types definition of modified exports.is required).
Reviewers
@AbhayVAshokan _a