Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize pasting text/plain if both text/plain and text/image are copied into the clipboard #1328

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

AbhayVAshokan
Copy link
Member

@AbhayVAshokan AbhayVAshokan commented Feb 20, 2025

Description

  • Microsoft Excel and a few other products might copy content as both text/plain and text/html. If text/plain exists, an early return will ensure that it fallbacks to tiptap's default paste behavior.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

https://abhay-ashokan.neetorecord.com/watch/5a0610a7f7c3583930a6

@AbhayVAshokan AbhayVAshokan added the patch Releases small requests or bug fixes. label Feb 20, 2025
@AbhayVAshokan AbhayVAshokan self-assigned this Feb 20, 2025
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1328 February 20, 2025 12:46 Inactive
@neetodeploy neetodeploy bot had a problem deploying to neeto-editor-ht2z-pr-1328 February 20, 2025 12:47 Failure
@AbhayVAshokan
Copy link
Member Author

Released v1.45.8-beta.0.

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1328 February 20, 2025 12:59 Inactive
@AbhayVAshokan
Copy link
Member Author

AbhayVAshokan commented Feb 20, 2025

@AbhayVAshokan
Copy link
Member Author

@sagar18041 _a: Can you please help me test the above PR and let me know if this is the expected behavior?

@neetogit-bot neetogit-bot bot assigned sagar18041 and unassigned harshitasingh24 Feb 20, 2025
@sagaranadkat
Copy link

@AbhayVAshokan https://sagar-anadkat.neetorecord.com/watch/d008d8c6dc27765ac7d5

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1328 February 21, 2025 07:50 Inactive
@AbhayVAshokan
Copy link
Member Author

AbhayVAshokan commented Feb 21, 2025

@sagar18041 _a can you please test the changes once again?

@AbhayVAshokan
Copy link
Member Author

Sorry, @sagaranadkat _a can you please test the changes once again?

@sagaranadkat
Copy link

@AbhayVAshokan https://sagar-anadkat.neetorecord.com/watch/71032ac0f456c05598e3

@AbhayVAshokan
Copy link
Member Author

Trying different things is hard for this issue since it is not reproducible for me. Let me try different approaches.

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1328 February 21, 2025 15:46 Inactive
@AbhayVAshokan
Copy link
Member Author

@sagaranadkat helped me verify the changes in NeetoKB. Merging the changes.

https://sagar-anadkat.neetorecord.com/watch/847871f2dc50e6dae218

@AbhayVAshokan AbhayVAshokan merged commit cd2131a into main Feb 21, 2025
@AbhayVAshokan AbhayVAshokan deleted the 1305-content-pasted-as-an-image branch February 21, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting copied text from excel or word document is pasted as image
4 participants