Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong order in filtering out the empty values and numbers less than one. #1255

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Oct 29, 2024

Fixes https://github.com/bigbinary/neeto-planner-web/issues/6838

Description
From storybook demo with the same content from the issue in planner.
image

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp
Copy link
Contributor Author

deepakjosp commented Oct 29, 2024

I was not able to test this in planner, since the ./bin/setup is not working in planner. Tested in NeetoPlanner. @AbhayVAshokan _a please review.

image

@labeebklatif
Copy link
Contributor

I was not able to test this in planner, since the ./bin/setup is not working in planner. @AbhayVAshokan _a please review.

@deepakjosp The development environment of neetoPlanner is now fixed if you would like to test the changes in planner and confirm. https://github.com/bigbinary/neeto-planner-web/pull/6825

@AbhayVAshokan AbhayVAshokan merged commit 57fe4a0 into main Oct 30, 2024
@AbhayVAshokan AbhayVAshokan deleted the 6838-neeto-planner-frontendproduction-typeerror-cannot-read-properties-of-undefined-reading-style branch October 30, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants