Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates EditorContent to support adding anchor tags around headers for easy navigation. #1253

Merged
merged 15 commits into from
Oct 28, 2024
Merged

Updates EditorContent to support adding anchor tags around headers for easy navigation. #1253

merged 15 commits into from
Oct 28, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Oct 23, 2024 •
edited
Loading

Fixes #1252

Description
EditorContent
image
NeetoWebsite
image
Rails template
image

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1253 October 23, 2024 10:01 Inactive
@deepakjosp deepakjosp self-assigned this Oct 23, 2024
@deepakjosp deepakjosp marked this pull request as draft October 23, 2024 10:01
@deepakjosp
Created the util function to make headers navigable in the EditorCont…
f6219fd 
…ent component and invoked the function based on the passed configuration.
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1253 October 23, 2024 11:34 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1253 October 24, 2024 08:41 Inactive
@neetodeploy neetodeploy bot had a problem deploying to neeto-editor-ht2z-pr-1253 October 24, 2024 08:46 Failure
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1253 October 24, 2024 08:58 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1253 October 24, 2024 09:06 Inactive
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Oct 24, 2024
@deepakjosp deepakjosp marked this pull request as ready for review October 24, 2024 09:06
@deepakjosp
Copy link
Contributor Author

deepakjosp commented Oct 24, 2024 •
edited
Loading

@AbhayVAshokan _a please review.

I've used the Script component in NextJS to fetch the scripts when the page is loaded on the browser.

      <Script
        src="https://cdn.jsdelivr.net/npm/@bigbinary/neeto-editor/dist/codeBlockHighlight.js"
        strategy="beforeInteractive"
      />

cc: @praveen-murali-ind

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned deepakjosp Oct 24, 2024
AbhayVAshokan
AbhayVAshokan approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakjosp _a:

  1. Mention about the above comment in the story (Output/Docs)
  2. Update the props table in Output/Docs.
  3. https://abhay-ashokan.neetorecord.com/watch/c94f8737-7185-4ff7-881c-aa773dc7a806

@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned AbhayVAshokan Oct 24, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1253 October 28, 2024 03:37 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1253 October 28, 2024 03:55 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ht2z-pr-1253 October 28, 2024 04:09 Inactive
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan implemented the suggestions. @praveen-murali-ind _a please review.

praveen-murali-ind
praveen-murali-ind approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@praveen-murali-ind praveen-murali-ind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@praveen-murali-ind praveen-murali-ind merged commit 515f9a0 into main Oct 28, 2024
@praveen-murali-ind praveen-murali-ind deleted the 1252-update-editorcontent-to-support-adding-anchor-tags-around-headers-for-easy-navigation branch October 28, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveen-murali-ind praveen-murali-ind praveen-murali-ind approved these changes

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@praveen-murali-ind praveen-murali-ind

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update EditorContent to support adding anchor tags around headers for easy navigation.
3 participants
@deepakjosp @AbhayVAshokan @praveen-murali-ind