Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds highlight lines feature to the code block. #1233

Merged
merged 13 commits into from
Oct 6, 2024
Merged

Adds highlight lines feature to the code block. #1233

merged 13 commits into from
Oct 6, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Oct 4, 2024 •
edited
Loading

Fixes #1220

Description

  • Adds feature to toggle line highlights in code block component.

EditorContent:
image

Editor:
image

codeBlockHighlight.js
image

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp
Updated the CodeBlock component to render the highlight button when t…
edbdc1f 
…here's a text selection.
@deepakjosp
Implemented the handle highlight function to set the selected line nu…
73bec94 
…mbers as data attributes.
@deepakjosp
Created a plugin that can add highlight style to the selected lines o…
06cdadd 
…f code.
@deepakjosp
Added the hightlight plugin and addAttributes to set the attributes b…
e3bb44f 
…ased on the line selection.
@deepakjosp
Fixed editor content ignoring existing highlight information.
4c2e5e8
@deepakjosp
Implemented the code highlight preview feature in EditorContent.
201bfcb
@deepakjosp
Modify the handle selection callback to properly toggle the highlight…
f047b69 
… based on the selection.
@deepakjosp
Added tooltip text to the highlight button.
7bf5321
@deepakjosp
Added highlightLine feature to the codeBlockhight.js
52be834
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1233 October 4, 2024 12:39 Inactive
@deepakjosp deepakjosp self-assigned this Oct 4, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1233 October 5, 2024 09:12 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1233 October 5, 2024 09:19 Inactive
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Oct 5, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1233 October 6, 2024 03:16 Inactive
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review.

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned deepakjosp Oct 6, 2024
AbhayVAshokan
AbhayVAshokan approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 👌

@AbhayVAshokan AbhayVAshokan merged commit 7e5300f into main Oct 6, 2024
@AbhayVAshokan AbhayVAshokan deleted the 1220-add-highlight-lines-feature-to-the-code-block branch October 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@AbhayVAshokan AbhayVAshokan

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Highlight Lines" feature to the code block
2 participants
@deepakjosp @AbhayVAshokan