Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with copying and pasting the images. #1223

Merged
merged 11 commits into from
Sep 26, 2024
Merged

Fixes issue with copying and pasting the images. #1223

merged 11 commits into from
Sep 26, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Sep 23, 2024 •
edited
Loading

Fixes #1219

Description

  • Fixed the missing feedback while the image is uploading.
  • Fixed issues when uploading multiple images.
  • Fixed issues in the onUpdate callback not firing sometimes when the image is added.
  • Moved all the errors in the step to a single place.
  • Updated the renderHtml to not render the image node if the src is not present.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1223 September 23, 2024 12:09 Inactive
@deepakjosp deepakjosp self-assigned this Sep 23, 2024
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Sep 24, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1223 September 24, 2024 07:13 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1223 September 24, 2024 07:39 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1223 September 24, 2024 08:50 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1223 September 24, 2024 10:08 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1223 September 24, 2024 11:57 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1223 September 25, 2024 03:16 Inactive
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review.

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned deepakjosp Sep 25, 2024
@AbhayVAshokan AbhayVAshokan merged commit 8fffa31 into main Sep 26, 2024
@AbhayVAshokan AbhayVAshokan deleted the 1219-issue-with-copying-and-pasting-the-image branch September 26, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@AbhayVAshokan AbhayVAshokan

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with copying and pasting the image
2 participants
@deepakjosp @AbhayVAshokan