Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed flickers while closing modals and added data-cy to uploader tabs #1060

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Removed flickers while closing modals and added data-cy to uploader tabs #1060

merged 1 commit into from
Apr 3, 2024

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented Apr 3, 2024

Description

  • Fixed: flickers while closing modal
  • Added: data-cy

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.

  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@gaagul _a

@gaagul gaagul added the patch Releases small requests or bug fixes. label Apr 3, 2024
@gaagul gaagul merged commit be55a44 into main Apr 3, 2024
@gaagul gaagul deleted the 1046-modal-state-reset-and-transition branch April 3, 2024 19:50
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1060 April 3, 2024 19:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan Awaiting requested review from AbhayVAshokan AbhayVAshokan is a code owner

Assignees

@gaagul gaagul

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add separate data-cy labels for upload and link tab in image upload Flicker on editor image upload file size
1 participant
@gaagul