Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets min-width to the emoji picker container to prevent width changes and placement problems once the content is loaded. #1054

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Mar 28, 2024

Description
The emoji picker was misplaced the first time because the container width changes when the emojis are loaded. A min-width is added to fix this issue.

Before

emoji-picker-before

After

emoji-picker-after

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

… and placement problems once the content is loaded.
@deepakjosp deepakjosp added patch Releases small requests or bug fixes. frontend Deals with React/JS code majorly. It can also include UI fixes without the help of the UI team. labels Mar 28, 2024
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review.

@AbhayVAshokan AbhayVAshokan merged commit 6d630e8 into main Mar 28, 2024
@AbhayVAshokan AbhayVAshokan deleted the fixes-emojis-are-partially-hidden branch March 28, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Deals with React/JS code majorly. It can also include UI fixes without the help of the UI team. patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants