-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test id for menu #1024
Added test id for menu #1024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sreehari2003 A few questions,
Questions
- Why are we going through all these steps for adding a data-cy label? Button has option for other props. So just add the "data-cy" label in the buttonProps?
- Why are we adding a data-test-id label when we use data-cy labels in our tests?
- Even if you're adding a test-id, it should
data-testid
and notdata-test-id
- Why are we not using the hyphenize utlity from neetoCist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sreehari2003 _a Please make sure you're taking care of all the review suggestions before re-assigning.
bbf5df0
to
901fee3
Compare
|
c51d3f5
to
86d97ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sreehari2003 _a LGTM
Description
Checklist
is required).
I have added data cy labels for all the menu buttons
Reviewers