Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test id for menu #1024

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Added test id for menu #1024

merged 8 commits into from
Mar 21, 2024

Conversation

SreehariJayaraj
Copy link
Contributor

Description

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).
Screenshot 2024-03-07 at 2 09 47 PM

I have added data cy labels for all the menu buttons

Reviewers

Copy link
Contributor

@VarunSriram99 VarunSriram99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreehari2003 A few questions,

Questions

  • Why are we going through all these steps for adding a data-cy label? Button has option for other props. So just add the "data-cy" label in the buttonProps?
  • Why are we adding a data-test-id label when we use data-cy labels in our tests?
  • Even if you're adding a test-id, it should data-testid and not data-test-id
  • Why are we not using the hyphenize utlity from neetoCist?

@SreehariJayaraj
Copy link
Contributor Author

@sreehari2003 A few questions,

Questions

  • Why are we going through all these steps for adding a data-cy label? Button has option for other props. So just add the "data-cy" label in the buttonProps?
  • Why are we adding a data-test-id label when we use data-cy labels in our tests?
  • Even if you're adding a test-id, it should data-testid and not data-test-id
  • Why are we not using the hyphenize utlity from neetoCist?
Screenshot 2024-03-09 at 8 41 47 PM

hyphenate is not available to import

Copy link
Contributor

@VarunSriram99 VarunSriram99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreehari2003 _a Please make sure you're taking care of all the review suggestions before re-assigning.

@VarunSriram99
Copy link
Contributor

@sreehari2003 A few questions,
Questions

  • Why are we going through all these steps for adding a data-cy label? Button has option for other props. So just add the "data-cy" label in the buttonProps?
  • Why are we adding a data-test-id label when we use data-cy labels in our tests?
  • Even if you're adding a test-id, it should data-testid and not data-test-id
  • Why are we not using the hyphenize utlity from neetoCist?
Screenshot 2024-03-09 at 8 41 47 PM hyphenate is not available to import

@sreehari2003 its hyphenate. Please go through all the neeto-cist and Playwright commons utilities carefully to make sure we're not repeating the logic.

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-pr-1024 March 11, 2024 12:57 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-pr-1024 March 12, 2024 12:26 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-pr-1024 March 13, 2024 14:49 Inactive
@SreehariJayaraj
Copy link
Contributor Author

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-pr-1024 March 14, 2024 05:29 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-pr-1024 March 14, 2024 07:29 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-pr-1024 March 14, 2024 08:13 Inactive
@AbhayVAshokan AbhayVAshokan mentioned this pull request Mar 14, 2024
@neetodeploy neetodeploy bot had a problem deploying to neeto-editor-pr-1024 March 14, 2024 12:28 Failure
@neetodeploy neetodeploy bot had a problem deploying to neeto-editor-pr-1024 March 14, 2024 12:31 Failure
@neetodeploy neetodeploy bot had a problem deploying to neeto-editor-pr-1024 March 18, 2024 05:29 Failure
@neetodeploy neetodeploy bot had a problem deploying to neeto-editor-pr-1024 March 18, 2024 15:06 Failure
Copy link
Contributor

@VarunSriram99 VarunSriram99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreehari2003 _a LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add data-cy label for Menu component
5 participants