fix: handle case when no logs are available for today during export

biersoeckli · Feb 2, 2025 · 5bc7209 · 5bc7209
1 parent 84e2fcc
commit 5bc7209
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/app/project/app/[appId]/overview/actions.ts b/src/app/project/app/[appId]/overview/actions.ts
@@ -12,6 +12,7 @@ import { getAuthUserSession, simpleAction } from "@/server/utils/action-wrapper.
 import { PodsResourceInfoModel } from "@/shared/model/pods-resource-info.model";
 import appLogsService from "@/server/services/standalone-services/app-logs.service";
 import { DownloadableAppLogsModel } from "@/shared/model/downloadable-app-logs.model";
+import { ServiceException } from "@/shared/model/service.exception.model";
 
 
 export const getDeploymentsAndBuildsForApp = async (appId: string) =>
@@ -56,5 +57,9 @@ export const getDownloadableLogs = async (appId: string) =>
 export const exportLogsToFileForToday = async (appId: string) =>
     simpleAction(async () => {
         await getAuthUserSession();
-        return new SuccessActionResult(await appLogsService.writeAppLogsToDiskForApp(appId));
+        const result = await appLogsService.writeAppLogsToDiskForApp(appId);
+        if (!result) {
+            throw new ServiceException('There are no logs available for today.');
+        }
+        return new SuccessActionResult();
     }) as Promise<ServerActionResult<unknown, DownloadableAppLogsModel | undefined>>;
diff --git a/src/server/services/standalone-services/app-logs.service.ts b/src/server/services/standalone-services/app-logs.service.ts
@@ -130,6 +130,9 @@ class AppLogsService {
         const logFilePath = PathUtils.appLogsFile(app.id, startOfDay);
         await FsUtils.deleteFileIfExists(logFilePath); // delete existing log file --> new one will be created
 
+        if (logPathsWritten.length === 0) {
+            return;
+        }
 
         await create({
             gzip: true,
@@ -142,7 +145,7 @@ class AppLogsService {
         }
 
         for (const logPath of logPathsWritten) {
-            //await FsUtils.deleteFileIfExists(logPath);
+            await FsUtils.deleteFileIfExists(logPath);
         }
 
         return {