Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: cloud paths checking against patterns #1094

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Oct 14, 2024

  1. fix for cloud paths

    The _check_path_matches_patterns function was failing for cloud (e.g.
    s3, gc3) URIs.
    
     1) the path.relative_to() function doesn't work for cloud URIs
    (it just returns the original).
     2) combining Path('/') with the result of relative_to now also throws
    an error when using cloud (or non-posix) paths.
    
    This fix drops the uri prefix by using .path to get the posix-like
    part of the path, so that the regex check works as expected.
    akhanf committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a9b32a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. revert version change

    was just for local use
    akhanf authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    76b057a View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. fix for remote uris

    The check if in a derivatives folder was not working when the root had a
    uri prefix. This fixes it so the uri prefix is stripped off for the
    check.
    akhanf committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    07bdfcd View commit details
    Browse the repository at this point in the history
  2. adds a simple test for remote s3 datasets

    Checks the number of files in an example openneuro s3 dataset. Also adds
    s3fs as a test dependency.
    akhanf committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    c9f7c1f View commit details
    Browse the repository at this point in the history