Messages #81
Merged
Messages #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@Remi-Gau I fixed the tests. You're welcome to take a look if the physioevents part needs refactoring and/or make it more efficient, it's a bit slow |
Remi-Gau
commented
Jun 27, 2024
tests/test_edf2bids.py
Outdated
Comment on lines
543
to
544
| ("vergence", ["Left", "Right"]), | ||
| ("2eyes", ["Left", "Right"]), |
There was a problem hiding this comment.
isn't that a repeat from the lines above?
There was a problem hiding this comment.
Yes. At some point something went wrong when I pulled and suddenly I had everything double. I probably missed that one.
for more information, see https://pre-commit.ci
Remi-Gau
commented
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.