Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] properly extract validation values #78

Merged
merged 4 commits into from
Jun 26, 2024
Merged

[FIX] properly extract validation values #78

merged 4 commits into from
Jun 26, 2024

Conversation

Remi-Gau
Copy link
Contributor

No description provided.

julia-pfarr and others added 2 commits June 20, 2024 16:58
@julia-pfarr
Tried to fix bugs, but failed
7465ba5 
edf2asc suddenly gives out a random order for the calibration positions. E.g., calibration point 3 is listed after calibration point 4. That's why I had to change the function _extract_Calibration poisition (as well as _get_calibration_positions). However, now the tests are failing because something is wrong with the lists in lists thingi and also it tries to get the calibration positions also for the testfiles which have none. I thought I specified that within the functions but obviously it doesn't work.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d8b812e 
for more information, see https://pre-commit.ci
@julia-pfarr
Copy link
Member

just realized that

def _extract_CalibrationUnit(df: pd.DataFrame) -> str:
    if len(_extract_CalibrationPosition(df)) == 0: 
        return ""

also makes troubles...

@Remi-Gau Remi-Gau changed the title [FIX] [FIX] properly extract validation values Jun 26, 2024
@Remi-Gau Remi-Gau merged commit 8a94e1c into main Jun 26, 2024
5 of 6 checks passed
@Remi-Gau Remi-Gau deleted the fix-bugs branch June 26, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Remi-Gau @julia-pfarr