Skip to content

Enh/read parquet files #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Enh/read parquet files #197

wants to merge 2 commits into from

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Apr 14, 2025

Use hyparquet library to read read parquet files.Transforms them into a columns map, which may not be desirable. Parquet files have good typing metadata that is thrown away and this implementation, with everything becoming a string like when we read in TSV files. Type checking is then done via regex as per schema.objects.columns/schema.objects.formats entries.

Still need to implement maxRows.

@rwblair
Copy link
Member Author

rwblair commented Apr 14, 2025

After chat with @effigies, context.columns could become a union type with TSVs still using the old ColumnMap type, and parquets using whatever representation we choose for them. In applyRules validation we can rely on context extension to decide how to validate columns field. Parquet validation could then convert its known built in types to schema types to check against the schema.objects.columns types. This would get around type checking every value in a given column like we do for TSVs (and using regexes to do that type checking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant