Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCHEMA] Reorganize schema code into a package #892

Merged
merged 38 commits into from
Jan 5, 2022
Merged

[SCHEMA] Reorganize schema code into a package #892

merged 38 commits into from
Jan 5, 2022

Commits on Oct 5, 2021

  1. Start reorganizing.

    @tsalo
    tsalo committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    b5e745e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into schema-package

    @tsalo
    tsalo committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    2bf9b6a View commit details
    Browse the repository at this point in the history

  3. Clean up docstrings.

    @tsalo
    tsalo committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    2cbcffc View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Change license to MIT.

    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    13044ba View commit details
    Browse the repository at this point in the history

  2. Fix spelling in versioneer files.

    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    73e89c5 View commit details
    Browse the repository at this point in the history

  3. Install schemacode in config file.

    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    4b59f93 View commit details
    Browse the repository at this point in the history

  4. Update config.yml

    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    5df0354 View commit details
    Browse the repository at this point in the history

  5. Fix path to schema. 

    I don't like this. We need something less dependent on folder locations.
    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    5383948 View commit details
    Browse the repository at this point in the history

  6. Log.

    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    f2492f8 View commit details
    Browse the repository at this point in the history

  7. Why isn't CircleCI working? 

    It works locally...
    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    4d594f4 View commit details
    Browse the repository at this point in the history

  8. Make loading function more restrictive.

    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    2c7db1a View commit details
    Browse the repository at this point in the history

  9. Move rendering functions into a new module.

    @tsalo
    tsalo committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    a3e7dfe View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2021

  1. RF: Use setup.cfg over info.py

    @effigies
    effigies committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    1a7e713 View commit details
    Browse the repository at this point in the history

  2. ENH: Link schema code into package

    @effigies
    effigies committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    74b5e31 View commit details
    Browse the repository at this point in the history

  3. RF: Use packaged schema

    @effigies
    effigies committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    af516d8 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into schema-package

    @effigies
    effigies committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    7d9daec View commit details
    Browse the repository at this point in the history

  5. MNT: Require schemacode package to build docs

    @effigies
    effigies committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    fadc12c View commit details
    Browse the repository at this point in the history

  6. Fix locations of functions.

    @tsalo
    tsalo committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    61b13fe View commit details
    Browse the repository at this point in the history

  7. Add a couple of tests.

    @tsalo
    tsalo committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    43c7a37 View commit details
    Browse the repository at this point in the history

  8. Draft a couple more tests.

    @tsalo
    tsalo committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    3b54a61 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Draft Action for schemacode CI. 

    I based this one off of a similar Action in nilearn. It'll probably require some debugging...
    @tsalo
    tsalo committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    376fbcb View commit details
    Browse the repository at this point in the history

  2. Fix installation.

    @tsalo
    tsalo committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    1332c9e View commit details
    Browse the repository at this point in the history

  3. Update schemacode_ci.yml

    @tsalo
    tsalo committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    7858106 View commit details
    Browse the repository at this point in the history

  4. Add badge.

    @tsalo
    tsalo committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    2e48e7d View commit details
    Browse the repository at this point in the history

  5. Add schema-related files to the CODEOWNERS file.

    @tsalo
    tsalo committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    963ad61 View commit details
    Browse the repository at this point in the history

  6. Run versioneer 0.21 instead of 0.18 and run black.

    @tsalo
    tsalo committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    31bcd19 View commit details
    Browse the repository at this point in the history

  7. Add numpy back in as a general dependency.

    @tsalo
    tsalo committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    f766804 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Yaroslav Halchenko <[email protected]>
    @tsalo @yarikoptic
    tsalo and yarikoptic authored Dec 18, 2021
    Configuration menu
    Copy the full SHA
    181df00 View commit details
    Browse the repository at this point in the history

  2. Add path restriction to pull requests too.

    @tsalo
    tsalo committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    2557616 View commit details
    Browse the repository at this point in the history

  3. Add license badge.

    @tsalo
    tsalo committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    e19f103 View commit details
    Browse the repository at this point in the history

  4. Try out linting job.

    @tsalo
    tsalo committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    cc5ed8e View commit details
    Browse the repository at this point in the history

  5. Fix name.

    @tsalo
    tsalo committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    a71a323 View commit details
    Browse the repository at this point in the history

  6. Don't use the flake8 action.

    @tsalo
    tsalo committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    ce53a66 View commit details
    Browse the repository at this point in the history

  7. Change working directory to use config.

    @tsalo
    tsalo committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    712a1f6 View commit details
    Browse the repository at this point in the history

  8. Run black on versioneer files.

    @tsalo
    tsalo committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    cf9b6b7 View commit details
    Browse the repository at this point in the history

  9. Fix linting issue.

    @tsalo
    tsalo committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    e4d3f08 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Apply @effigies' suggestions 

    Thanks for the suggestions!

Co-authored-by: Chris Markiewicz <[email protected]>
    @tsalo @effigies
    tsalo and effigies authored Jan 5, 2022
    Configuration menu
    Copy the full SHA
    adeeeed View commit details
    Browse the repository at this point in the history

  2. Remove unused imports.

    @tsalo
    tsalo committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    97794d5 View commit details
    Browse the repository at this point in the history