fix(checks): Enforce timing mutual exclusions on BOLD/ASL data only #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1969 +/- ##
=======================================
Coverage 86.99% 86.99%
=======================================
Files 16 16
Lines 1407 1407
=======================================
Hits 1224 1224
Misses 183 183 ☔ View full report in Codecov by Sentry. |
effigies
added
schema
|
It seems like it could apply to ASL, but TBH I don't know for sure. I say we include ASL and change it if an ASL user raises a valid concern. |
effigies
force-pushed
the
fix/bold-timing
branch
from
bfc706a
to
638819f
Compare
effigies
changed the title
tsalo
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins to address #1906 by at least containing the metadata complaints to BOLD files, which were the data that were intended to be checked. @tsalo Should this be expanded to include ASL as well?