Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIDS 2.0: harmonize TSV columns to be singular (ATM "units" and "migrate_plural_columns") #1821

Draft
wants to merge 3 commits into
base: bids-2.0
Choose a base branch
from

Conversation

yarikoptic
Copy link
Collaborator

@yarikoptic yarikoptic commented May 15, 2024

Closes

TODOs

  • review if any other renames are due (not necessarily plural -> singular but might be done along here)
  • decide on either renaming "units" to "unit" is worthwhile given that there is lots of "*Units" in sidecar fields: MINOR: Replace "units" with "unit" in channels.tsv bids-2-devel#15 (comment)
  • RECOMMEND for the user added columns to be singular
    • consider possibility for adding a check to bids-validator -- might be too tricky to be worth it since not trivial to determine plurality AFAIK
  • compliment with changes to "CONTRIBUTION" guide of some kind (@effigies please remind where should we place those)
    • add a test for schema tests to ensure that nobody inadvertently adds another plural column
      • might be worth for BIDS 1.0 with whitelisting of known 2 culprits so we prevent possibly adding more
  • implement migration code

@yarikoptic yarikoptic mentioned this pull request May 15, 2024
14 tasks
…tion

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi hplc_recovery_fractions hplc_recovery_fraction",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant