-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add optional low_cutoff and high_cutoff columns for fnirs channels.tsv #1597
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1597 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 16 16
Lines 1356 1356
=======================================
Hits 1191 1191
Misses 165 165 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems obviously right, given that examples submitted by the BEP leads include them, and there is a clear interpretation. Adding these will not invalidate or increase validator noise on any datasets, so I vote for merge after the usual 5 days, regardless of whether we hear back.
good with me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes total sense. Approved!
Going to invoke rule 5 and merge now, as it will eliminate a spurious validator error. |
makes it consistent with what is done in EEG, iEEG, MEG
See the HTML table here
@rob-luke @lpollonini does this make sense to you
Closes bids-standard/bids-examples#396.