Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Update teonbrooks' info for .tributors #1556

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

teonbrooks
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (334dd36) 87.83% compared to head (32c2941) 87.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1556   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sappelhoff sappelhoff requested a review from Remi-Gau July 19, 2023 09:15
@sappelhoff
Copy link
Member

Thanks Teon!

@Remi-Gau technically updating the .tributors file only would be the way to go, right? and then letting the CITATION.cff file be updated automatically upon next release?

@Remi-Gau
Copy link
Collaborator

Thanks Teon!

@Remi-Gau technically updating the .tributors file only would be the way to go, right? and then letting the CITATION.cff file be updated automatically upon next release?

yes that is correct: but I did open an issue to check that if only the citation.cff were to be updated we would know (some check in CI, or the update script would notify...)

@sappelhoff sappelhoff added the exclude-from-changelog This item will not feature in the automatically generated changelog label Jul 19, 2023
@sappelhoff sappelhoff merged commit 28beccd into master Jul 20, 2023
18 checks passed
@sappelhoff sappelhoff deleted the teonbrooks-patch-1 branch July 20, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants