[ENH] Allow UNKNOWN and NONE ContrastBolusIngredients

[Remi-Gau]

fixes #1542

• allows unkwown and none contrast agent

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (e05ba93) 87.83% compared to head (a7cb69c) 87.83%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1547   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[effigies]

@yarikoptic Does HeuDiConv need to know about this change?

[yarikoptic]

@yarikoptic Does HeuDiConv need to know about this change?

I don't think it is that smart to care ;)

[tsalo]

The change looks good to me. We might want to keep an eye out for this issue with similar entity-metadata field combos.

[Remi-Gau]

Task name comes to mind but this is already checked in the validator.
Doubt contrast agent is actually checked.

[effigies]

From older specs:

The key ContrastBolusIngredient MAY be also be added in the JSON file, with the same label.

It's never been even RECOMMENDED. Reading it, it almost seems like it should be disallowed except when ce- is present, but MRI does not disallow unknown metadata, so that doesn't seem sensible.

I think it would make sense to make it RECOMMENDED if ce- is present, which we can easily do in schema.

[Remi-Gau]

MRI does not disallow unknown metadata

Is that new?
From memory extra metadata was fine

[tsalo]

Oh actually NONE should probably just be n/a, right?

[effigies]

Oh actually NONE should probably just be n/a, right?

n/a is mainly a TSV convention. For JSON, I believe PET used it for REQUIRED fields that could sometimes be undefined for legitimate reasons, but that seems unnecessary for OPTIONAL/RECOMMENDED fields.

MRI does not disallow unknown metadata

Is that new?
From memory extra metadata was fine

Yes, extra metadata is fine, and not disallowed.

[Remi-Gau]

Is that new?
From memory extra metadata was fine

Yes, extra metadata is fine, and not disallowed.

#ApparentlyRémiCannotRead