Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add "visual correction" and "head stabilization" metadata #1539

Merged
merged 7 commits into from
Aug 17, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Jul 3, 2023

closes #1531

  • adds HeadStabilization to StimulusPresentation in events.json
  • adds VisualAids in events.json

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bdc3d55) 87.83% compared to head (395a699) 87.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1539   +/-   ##
=======================================
  Coverage   87.83%   87.83%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1191     1191           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Visual aid" is something that presents information visually. It is rarely-to-never used to refer to corrective eyewear. Would VisionCorrection work?

Otherwise, this seems fine.

src/schema/objects/metadata.yaml Outdated Show resolved Hide resolved
src/modality-specific-files/task-events.md Outdated Show resolved Hide resolved
src/schema/rules/sidecars/events.yaml Outdated Show resolved Hide resolved
@Remi-Gau
Copy link
Collaborator Author

"Visual aid" is something that presents information visually. It is rarely-to-never used to refer to corrective eyewear. Would VisionCorrection work?

yes that would make sense to me: will ping some of the people on the eyetracking BEP to make sure that it is good with them too.

Co-authored-by: Chris Markiewicz <[email protected]>
@Remi-Gau Remi-Gau mentioned this pull request Jul 14, 2023
9 tasks
@Remi-Gau Remi-Gau changed the title [ENH] add visual aids and head stabilization metadata [ENH] add "visual correction" and "head stabilization" metadata Jul 14, 2023
src/schema/objects/metadata.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I assume the eye tracking bep has had a chance to object.

@Remi-Gau Remi-Gau merged commit b03b8ae into bids-standard:master Aug 17, 2023
18 checks passed
@Remi-Gau Remi-Gau deleted the head_stab branch August 17, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestions for new task metadata: HeadStabilization and VisualAids
3 participants