Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Make sure version docker images matches version of package in the image #169

Merged
merged 4 commits into from
Sep 1, 2024

Conversation

Remi-Gau
Copy link
Collaborator


unrelated

speed CLI response to --help or --version by doing local imports after parsing CLI arguments

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this verbose content is pretty much a copy of of the gitingore to ensure that only tracked files will be copied in the docker image

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.03%. Comparing base (a384992) to head (df40338).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          18       18           
  Lines         754      754           
=======================================
  Hits          709      709           
  Misses         45       45           
Files with missing lines Coverage Δ
giga_connectome/run.py 95.34% <100.00%> (ø)

@Remi-Gau Remi-Gau requested a review from htwangtw August 13, 2024 10:59
@Remi-Gau Remi-Gau merged commit eb9a18f into bids-apps:main Sep 1, 2024
26 checks passed
@Remi-Gau Remi-Gau deleted the fix/168 branch September 1, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] docker version does not match giga_connectome version
1 participant