Attempt to fix borked undo (user gets caught in an undo loop) #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs the latest Vim (8.1) with patch 245. The idea is to invoke parinfer only during regular edits but not after an undo since invoking parinfer after an undo creates a branch in the undo tree causing previous changes to not be easily reachable and the user to be caught in an undo loop.
|
I almost stopped using parinfer because of this problem... I am going to give it a go, and confirm if this actually fixes the problem. |
Open
|
This is really old and I haven't been clojur-ing for a while. Should I close this? |
|
yea this bug really is a pain. I'm actually favoring using https://github.com/eraserhd/parinfer-rust now and it has similar issues with undo. Really not sure how best to address but could give this a test run |
|
Closing, been open for a long time and I'm not actively using the plugin at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs the latest Vim (8.1) with patch 245.
The idea is to invoke parinfer only during regular edits but not after an undo since invoking parinfer after an undo creates a branch in the undo tree causing previous changes to not be easily reachable and the user to be caught in an undo loop.
Not sure if the
try... undojointhing is the best approach - happy to use a better alternative if there is one.