Skip to content

Commit

Permalink
Pin lalsuite version and fix error in pycbc_plot_singles_vs_params (g…
Browse files Browse the repository at this point in the history
…wastro#4997)

* Fix

* SEOBNRV4 ROM version has updated

* Test blocking latest lalsuite version

* less than, not block

* Adding comment for why this is pinned
  • Loading branch information
GarethCabournDavies authored Dec 20, 2024
1 parent 2338883 commit 1d995f8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion bin/plotting/pycbc_plot_singles_vs_params
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ from matplotlib.colors import LogNorm
from matplotlib.ticker import LogLocator
import h5py
import sys
from packaging.version import Version

import pycbc
import pycbc.pnutils
Expand Down Expand Up @@ -148,7 +149,7 @@ hexbin_style = {

# In earlier versions mpl will try to take the max over bins with 0 triggers
# and fail, unless we tell it to leave these blank by setting mincnt
if matplotlib.__version__ < '3.8.1':
if Version(matplotlib.__version__) < Version('3.8.1'):
hexbin_style['mincnt'] = 0

if opts.log_x:
Expand Down
4 changes: 3 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ jinja2
mpld3>=0.3
beautifulsoup4>=4.6.0
cython
lalsuite!=7.2
# lalsuite 7.25 requires a data file which is not public
#- pinning temporarily until it is
lalsuite!=7.2,<7.25
lscsoft-glue>=1.59.3
ligo-segments
tqdm
Expand Down

0 comments on commit 1d995f8

Please sign in to comment.