Merge pull request #18 from bholmesdev/fix/prevent-default

Fix accidental form submission
bholmesdev · Jan 1, 2024 · bcc6373 · bcc6373
2 parents c524889 + 86034e4
commit bcc6373
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 0 deletions.
diff --git a/.changeset/hip-beers-listen.md b/.changeset/hip-beers-listen.md
@@ -0,0 +1,5 @@
+---
+"simple-stack-form": patch
+---
+
+Fix accidental form submission on client validation errors
diff --git a/examples/form/src/components/preact/Form.tsx b/examples/form/src/components/preact/Form.tsx
@@ -76,6 +76,7 @@ export function Form({
 						return formContext.trackAstroSubmitStatus();
 					}
 
+					e.preventDefault();
 					e.stopPropagation();
 					formContext.setValidationErrors(parsed.fieldErrors);
 				}}

diff --git a/examples/form/src/components/react/Form.tsx b/examples/form/src/components/react/Form.tsx
@@ -78,6 +78,7 @@ export function Form({
 						return formContext.trackAstroSubmitStatus();
 					}
 
+					e.preventDefault();
 					e.stopPropagation();
 					formContext.setValidationErrors(parsed.fieldErrors);
 				}}

diff --git a/packages/form/templates/preact/Form.tsx b/packages/form/templates/preact/Form.tsx
@@ -74,6 +74,7 @@ export function Form({
 						return formContext.trackAstroSubmitStatus();
 					}
 
+					e.preventDefault();
 					e.stopPropagation();
 					formContext.setValidationErrors(parsed.fieldErrors);
 				}}

diff --git a/packages/form/templates/react/Form.tsx b/packages/form/templates/react/Form.tsx
@@ -78,6 +78,7 @@ export function Form({
 						return formContext.trackAstroSubmitStatus();
 					}
 
+					e.preventDefault();
 					e.stopPropagation();
 					formContext.setValidationErrors(parsed.fieldErrors);
 				}}