-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Add dockerfile, fix some type errors, update type annotations, add some error-handling, formatting #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjjermiah
commented
Mar 15, 2024
- Add dockerfile
- setup continuous build on release
- also fixed gha to only push to pypi if there is a new release to prevent the errors from an existing release already uploaded
…bs for better clarity
…at with black for readability, refactor applyNegativeControl function to raise AssertionErrror for optional baseROI, handle edge case and raise error if none of the nc_types.
…ns, add type hints, and improve error handling, format with black
refactor: Fixes, updates, formatting
jjjermiah
changed the title
Added Dockerfile
Refactor: Add dockerfile, fix some type errors, update type annotations, add some error-handling, formatting
Mar 19, 2024
strixy16
reviewed
Mar 27, 2024
if nc_type == "randomized_full": | ||
# Make negative control version of ctImage (randomized pixel size) | ||
return makeRandomImage(baseImage) | ||
elif nc_type == "randomized_roi": | ||
elif nc_type == "shuffled_full": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two elif clauses moved here because they don't require the baseROI or roiLabel
strixy16
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.