Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Add dockerfile, fix some type errors, update type annotations, add some error-handling, formatting #15

Merged
merged 23 commits into from
Mar 27, 2024

Conversation

jjjermiah
Copy link
Contributor

  1. Add dockerfile
  2. setup continuous build on release
  • also fixed gha to only push to pypi if there is a new release to prevent the errors from an existing release already uploaded

@jjjermiah jjjermiah requested a review from strixy16 March 15, 2024 20:46
@jjjermiah jjjermiah changed the title Added Dockerfile Refactor: Add dockerfile, fix some type errors, update type annotations, add some error-handling, formatting Mar 19, 2024
if nc_type == "randomized_full":
# Make negative control version of ctImage (randomized pixel size)
return makeRandomImage(baseImage)
elif nc_type == "randomized_roi":
elif nc_type == "shuffled_full":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two elif clauses moved here because they don't require the baseROI or roiLabel

@strixy16 strixy16 merged commit 20f8d54 into main Mar 27, 2024
4 checks passed
@jjjermiah jjjermiah deleted the dockerfile branch October 22, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants