Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register figwheelApp to expo root if present and configured #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

register figwheelApp to expo root if present and configured #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions figwheel-bridge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ var ReactNative = require('react-native');
var createReactClass = require('create-react-class');
var URI = require("uri-js");
var cljsBootstrap = require("./clojurescript-bootstrap.js");
var expo = require('expo');

function cljsNamespaceToObject(ns) {
return ns.replace(/\-/, "_").split(/\./).reduce(function (base, arg) {
Expand Down Expand Up @@ -105,14 +106,15 @@ function validateOptions(options) {
assert(options.appName, "must provide an appName");
assertKeyType(options, "appName", "string");
assertKeyType(options, "autoRefresh", "boolean");
assertKeyType(options, "expo", "boolean");
assertKeyType(options, "renderFn", "string");
if(options.optionsUrl) {
assertKeyType(options, "optionsUrl", "string");
} else {
assert(options["asset-path"], "must provide an asset-path option when no cljscOptionsUrl is provided");
assert(options["main"], "must provide a main option when no cljscOptionsUrl is provided");
assertKeyType(options, "asset-path", "string");
assertKeyType(options, "main", "string");
assertKeyType(options, "main", "string");
if(options.preloads) {
assertKeyType(options, "preloads", "string");
}
Expand Down Expand Up @@ -146,9 +148,13 @@ function startApp(options){
// because the way that React Native launches an application. It looks for the registered application to launch
// after the initial loading of the jsbundle. Since we are accumstomed to use asynchronous loading to load
// the optimizations none files and setup its useful to establish this fetching as a channel for future reloading.
// We could compile the files to load into an initial single bundle to be loaded.
ReactNative.AppRegistry.registerComponent(
config.appName, () => figwheelApp(config));
// We could compile the files to load into an initial single bundle to be loaded.
if ( config.expo === true && expo !== undefined) {
expo.registerRootComponent(figwheelApp(config));
} else {
ReactNative.AppRegistry.registerComponent(
config.appName, () => figwheelApp(config));
}
}

module.exports = {
Expand Down