Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Instructions for using compose setup with minikube. #313

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

jmchilton
Copy link
Collaborator

No description provided.

- Use volumes_from instead of volumes so kompose can match up paths properly.
- Mount pgadmin4 without volumes when using kompose for now.
- Annotate the services that should be exposed externally with kompose labels in the source compose files.
@jmchilton
Copy link
Collaborator Author

Made some more progress here - switched compose setup to use volumes_from so that kompose can match up things properly.

Relevant pieces of SLURM docs:

```
Node names can have up to three name specifications: NodeName is the name used by all Slurm tools when referring to the node, NodeAddr is the name or IP address Slurm uses to communicate with the node, and NodeHostname is the name returned by the command /bin/hostname -s. Only NodeName is required (the others default to the same name), although supporting all three parameters provides complete control over naming and addressing the nodes. See the slurm.conf man page for details on all configuration parameters.
```

```
ControlAddr
Name that ControlMachine should be referred to in establishing a communications path. This name will be used as an argument to the gethostbyname() function for identification. For example, "elx0000" might be used to designate the Ethernet address for node "lx0000". By default the ControlAddr will be identical in value to ControlMachine.
```
@@ -76,7 +76,7 @@
#SlurmctldLogFile=
SlurmdDebug=3
#SlurmdLogFile=
NodeName=$hostname CPUs=$cpus RealMemory=$memory State=UNKNOWN
NodeName=$node_name NodeAddr=$hostname CPUs=$cpus RealMemory=$memory State=UNKNOWN
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, interesting!


# pgadmin can run without volumes and gets permission errors if not started this way in
# minikube.
del raw_compose_def["services"]["pgadmin4"]["volumes"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the volume than from compose if it's not needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is useful in the compose setup I'd imagine because it persists the configuration. It just didn't work when I tried under k8 - I think it could be made to though we just need to fix the permission errors.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange I'm hitting now the same problem in a normal compose setup :(

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the image got updated?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that, also an older one from 2 month ago does not work, very strange. Same permission errors that you got.
I will keep that on my todo list, not essential for now.

@bgruening
Copy link
Owner

@jmchilton I will use env vars in the compose file and provide .env files to customize deployments.
Before you clean the compose file to be used by kompose, can you please use docker-compose config to normalize it.

@bgruening
Copy link
Owner

I can also do this, if you prefer, of course!

@bgruening
Copy link
Owner

Here is an example: https://github.com/bgruening/docker-galaxy-stable/pull/323/files#diff-034c7c4e5b46ed32bd67817dd9af57f9
Rename it to .env and Galaxy will start on 8081.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants