Add stayrtr info (hostname and version) in metrics output #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested.
This diff should add the hostname and version in the metrics output.
Expected result:
```
# HELP rtr_info stayrtr info.
# TYPE rtr_info gauge
rtr_info{nodename="<hostname>",version="StayRTR 0.6.1"} 1
```
This would be similar to what bgplgd and rpki-client metrics offer:
```
# HELP bgpd bgpd information
# TYPE bgpd info
bgpd_info{nodename="<hostname>",domainname="<domainname>",release="8.6"} 1
```
or
```
# HELP rpki_client rpki-client information
# TYPE rpki_client gauge
rpki_client_info{nodename="<hostname>",domainname="<domainname>",release="9.3"} 1
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds the hostname, domainname and version in the metrics output.
metrics.out.log
This is similar to what bgplgd and rpki-client metrics offer:
or
This makes it possible to use the name in grafana dashboards, for example.