Naming is hard #107
Merged
Naming is hard #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depending if it is the array of SD or a single item.
The toplevel JSON object is now RPKIList and it contains VRPJson, VAPJson and BgpSecKeyJson objects.
is more in it now.
of VRPs but the number of objects in the cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup some code that is just confusing because the variables and functions are inappropriately named.
While I can handle ROA vs VRP and ASPA vs VAP, it breaks my mind when VRP refers to all objects in the cache.
Mainly use RPKI for the top level structure that includes VRP, VAP and BgpsecKeys.
Use VAP instead of aspa (at least in those places where VRP is used instead of ROA).
Use items for SendableData objects since those can be VRP, VAP or BgpsecKeys.
Kill a unused function and variable in the server code.