Store hash before decoding, do not parse broken file twice

bgp · Feb 29, 2024 · 460d315 · 460d315
1 parent c3652d3
commit 460d315
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/cmd/stayrtr/stayrtr.go b/cmd/stayrtr/stayrtr.go
@@ -517,13 +517,13 @@ func (s *state) updateFile(file string) (bool, error) {
 	}
 
 	log.Infof("new cache file: Updating sha256 hash %x -> %x", s.lasthashCache, hsum)
+	s.lasthashCache = hsum
 
 	rpkilistjson, err := decodeJSON(data)
 	if err != nil {
 		return false, err
 	}
 
-	s.lasthashCache = hsum
 	s.lastchange = time.Now().UTC()
 	s.lastdata = rpkilistjson
 
@@ -550,14 +550,15 @@ func (s *state) updateSlurm(file string) (bool, error) {
 			return false, IdenticalFile{File: file}
 		}
 	}
+	log.Infof("new slurm file: Updating sha256 hash %x -> %x", s.lasthashCache, hsum)
+	s.lasthashSlurm = hsum
 
 	buf := bytes.NewBuffer(data)
 
 	slurm, err := prefixfile.DecodeJSONSlurm(buf)
 	if err != nil {
 		return false, err
 	}
-	s.lasthashSlurm = hsum
 	s.slurm = slurm
 	return true, nil
 }
@@ -664,12 +665,12 @@ func (s *state) exporter(wr http.ResponseWriter, r *http.Request) {
 }
 
 type state struct {
-	lastdata   *prefixfile.RPKIList
-	lasthashCache   []byte
-	lasthashSlurm   []byte
-	lastchange time.Time
-	lastts     time.Time
-	sendNotifs bool
+	lastdata      *prefixfile.RPKIList
+	lasthashCache []byte
+	lasthashSlurm []byte
+	lastchange    time.Time
+	lastts        time.Time
+	sendNotifs    bool
 
 	fetchConfig *utils.FetchConfig