Modernize usage of autoconf macros #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
autoreconf --install
(also art of./bootstrap
), some warnings related toautoconf
are raised:AC_PROG_CC_STDC
is meanwhile done byAC_PROG_CC
, see: https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.htmlAC_PROG_LIBTOOL
can be replaced byLT_INIT
since libtool v2, dates back to ~ 2008, see also: https://autotools.info/forwardporting/libtool.htmlautoconf
loves square brackets ;-)Running
autoreconf --install
with the suggested changes applied looks finally like this:To avoid breaking builds of bgpq4 in maybe non-edge Linux distributions, I've also tested this change with both:
Note that autoconf 2.69 was released in April 2012. When looking to Repology, autoconf >= 2.69 seems to be in all common non-EOL distributions out there.