Skip to content

Commit

Permalink
Adds code coverage report the output of npm test and adds detailed …
Browse files Browse the repository at this point in the history
…… (#3575)

* Adds code coverage report the output of `npm test` and adds detailed html code coverage report using the command `npm run-script test-cov`

* Switch over to using functions in lib/ rather than dist/, so that code coverage stats are complete.

* Import vis at the top level to keep ItemSet passing

* Remove requirement for dist/vis in TimelineItemSet
  • Loading branch information
macleodbroad-wf authored and mojoaxel committed Jun 9, 2019
1 parent b037a34 commit 6ab6eb6
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 35 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
],
"main": "./dist/vis.js",
"scripts": {
"test": "mocha --compilers js:babel-core/register",
"test-cov": "nyc --reporter=lcov mocha --compilers js:babel-core/register",
"test": "nyc mocha --compilers js:babel-core/register",
"test-cov": "nyc --reporter=html mocha --compilers js:babel-core/register",
"build": "gulp",
"lint": "gulp lint",
"watch": "gulp watch",
Expand Down
6 changes: 2 additions & 4 deletions test/PointItem.test.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
var assert = require('assert');
var vis = require('../dist/vis');
var jsdom = require('mocha-jsdom');
var moment = vis.moment;
var timeline = vis.timeline;
var moment = require('../lib/module/moment');
var PointItem = require("../lib/timeline/component/item/PointItem");
var Range = timeline.Range;
var Range = require('../lib/timeline/Range');
var TestSupport = require('./TestSupport');

describe('Timeline PointItem', function () {
Expand Down
9 changes: 4 additions & 5 deletions test/TestSupport.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
var vis = require('../dist/vis');
var DataSet = vis.DataSet;
var DataSet = require('../lib/DataSet');

module.exports = {
buildMockItemSet: function() {
Expand Down Expand Up @@ -35,8 +34,8 @@ module.exports = {
},
hiddenDates: [],
util: {}
}
body.dom.rollingModeBtn = document.createElement('div')
};
body.dom.rollingModeBtn = document.createElement('div');
return body
}
}
};
8 changes: 3 additions & 5 deletions test/TimeStep.test.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
var assert = require('assert');
var vis = require('../dist/vis');
var jsdom = require('mocha-jsdom')
var moment = vis.moment;
var timeline = vis.timeline;
var TimeStep = timeline.TimeStep;
var jsdom = require('mocha-jsdom');
var moment = require('../lib/module/moment');
var TimeStep = require('../lib/timeline/TimeStep');
var TestSupport = require('./TestSupport');

describe('TimeStep', function () {
Expand Down
31 changes: 17 additions & 14 deletions test/TimelineItemSet.test.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,19 @@
var assert = require('assert');
var DataSet = require('../lib/DataSet');
var DateUtil = require('../lib/timeline/DateUtil');
var Range = require('../lib/timeline/Range');
var ItemSet = require('../lib/timeline/component/ItemSet');


describe('Timeline ItemSet', function () {
before(function () {
delete require.cache[require.resolve('../dist/vis')]
this.jsdom = require('jsdom-global')();
this.vis = require('../dist/vis');
var TestSupport = require('./TestSupport');
var rangeBody = TestSupport.buildSimpleTimelineRangeBody();
this.testrange = new this.vis.timeline.Range(rangeBody);
this.TestSupport = require('./TestSupport');

var rangeBody = this.TestSupport.buildSimpleTimelineRangeBody();
this.testrange = new Range(rangeBody);
this.testrange.setRange(new Date(2017, 1, 26, 13, 26, 3, 320), new Date(2017, 1, 26, 13, 26, 4, 320), false, false, null);
this.testitems = new this.vis.DataSet({
this.testitems = new DataSet({
type: {
start: 'Date',
end: 'Date'
Expand All @@ -18,11 +22,11 @@ describe('Timeline ItemSet', function () {
// add single items with different date types
this.testitems.add({id: 1, content: 'Item 1', start: new Date(2017, 1, 26, 13, 26, 3, 600), type: 'point'});
this.testitems.add({id: 2, content: 'Item 2', start: new Date(2017, 1, 26, 13, 26, 5, 600), type: 'point'});
})
});

after(function () {
this.jsdom();
})
});

var getBasicBody = function() {
var body = {
Expand Down Expand Up @@ -56,20 +60,20 @@ describe('Timeline ItemSet', function () {
},
util: {
}
}
};
return body;
};

it('should initialise with minimal data', function () {
var body = getBasicBody();
var itemset = new this.vis.timeline.components.ItemSet(body, {});
var itemset = new ItemSet(body, {});
assert(itemset);
});

it('should redraw() and have the right classNames', function () {
var body = getBasicBody();
body.range = this.testrange;
var itemset = new this.vis.timeline.components.ItemSet(body, {});
var itemset = new ItemSet(body, {});
itemset.redraw();
assert.equal(itemset.dom.frame.className, 'vis-itemset');
assert.equal(itemset.dom.background.className, 'vis-background');
Expand All @@ -80,14 +84,13 @@ describe('Timeline ItemSet', function () {

it('should start with no items', function () {
var body = getBasicBody();
var itemset = new this.vis.timeline.components.ItemSet(body, {});
var itemset = new ItemSet(body, {});
assert.equal(itemset.getItems(), null);
});

it('should store items correctly', function() {
var body = getBasicBody();
body.range = this.testrange;
var DateUtil = this.vis.timeline.DateUtil;
body.util.toScreen = function(time) {
return DateUtil.toScreen({
body: {
Expand All @@ -100,7 +103,7 @@ describe('Timeline ItemSet', function () {
}
}, time, 900)
};
var itemset = new this.vis.timeline.components.ItemSet(body, {});
var itemset = new ItemSet(body, {});
itemset.setItems(this.testitems);
assert.equal(itemset.getItems().length, 2);
assert.deepEqual(itemset.getItems(), this.testitems);
Expand Down
8 changes: 3 additions & 5 deletions test/TimelineRange.test.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
var assert = require('assert');
var vis = require('../dist/vis');
var jsdom = require('mocha-jsdom')
var moment = vis.moment;
var timeline = vis.timeline;
var Range = timeline.Range;
var jsdom = require('mocha-jsdom');
var moment = require('../lib/module/moment');
var Range = require('../lib/timeline/Range');
var TestSupport = require('./TestSupport');

describe('Timeline Range', function () {
Expand Down

0 comments on commit 6ab6eb6

Please sign in to comment.